Thanks Don,
On lacking details, sorry. I'll attempt to be more concise and provide enough details so questions can be answered. The previous script posted was only an exersize used to help me understand how getopts works via hands on testing. I was not understanding how it worked after reading the man page and other sources of info. I'm not educated or work in anything related to Unix or Linux. I'm only an aspiring hobbyist Linux user with the goal of obtaining enough of a grasp on shell scripting to contribute something meaningful enough to be considered for use by others.
Add info:
linux 4.14.12-1
bash 4.4.012-2
gawk 4.2.0-2
sed 4.4-1
I currently have a wrapper script (see below), that is parsing options based on positional parameters only. The script is used to automate some tasks that can be performed manually, dealing with building and installing packages from pre made "PKGBUILD" build scripts.
As a learning exercise on getopts usage, at this point I'd like to build a "drop in replacement" using getopts, to replace the manual option parsing in my existing script. This makes it necessary to reprocess multiple letter options after getopts, per the example posted below.
After I get my head around getopts, etc, I'll likely need to completely rewrite the script as it seems getopts usage would pretty much dictate how a script is written, unless I'm missing something.
I have experimented with testing the $OPTARG variable, but it seems to create more issues to work around in my use case than just not using it. I decided instead to focus on using the package list provided by the double quoted $@ parameter after being processed by getopts.
Although my script does not currently handle multiple packages per run, I'd like to include this ability with the eventual proper implementation of getopts.
There are undoubtedly too many errors in the scripts below to discuss at this time. I'd prefer focusing on getting answers to following questions please, unless there is obviously something important that I am missing, (as in spaces being included as options). Thanks and I was not aware of that.
1) How to pass a variable from a script to a function? Is it possible?
2) Best way to get "Package List" contents into the function per below sample test script? I've tried many ways, unsuccessfully as below. The only method working so far is to write the parameter contents to a file, then read it in the function, per post #1 test script above. I could also use awk, etc to filter the variable parameters each time I need the packages in a function, but seems there has to be a more efficient method.
#!/bin/bash
testfunc () {
echo "Package List : ${@}"
echo ===============================
}
while getopts "S" opt; do
case $opt in
S) testfunc "${@}"
;;
\?) echo "Invalid option: -$OPTARG"
;;
esac
done
shift $(($OPTIND -1))
echo "Package List : ${@}"
What I have so far for a "getopts drop in replacement" to replace the manual option parsing in script below.
#!/bin/bash
anyfunc () {
prgs=$(< /tmp/prgs)
echo "
Function
\$@ : ${@}
\$progs : $progs
\$prgs : $prgs
"
echo ========================================
}
while getopts "SvfRCDFsph" opt; do
case $opt in
S) S=S ; anyfunc "${@}" "$progs" ;;
v) v=v ; ;;
f) f=f ; ;;
R) R=-R ; ;;
C) C=-C ; ;;
D) D=-D ; ;;
F) F=-F ; ;;
s) s=-s ; ;;
p) p=-p ; ;;
h) h=-h ; ;;
\?) echo "Invalid option: -$OPTARG" ;;
esac
done
shift $(($OPTIND -1))
## ERROR
if [[ $f = f ]] && [[ $v = v ]]; then S=E ; v= ; f= ; echo " Option Errors" ; fi
if [[ -z $S ]] && [[ $v = v ]]; then S=E ; v= ; echo " Option Errors" ; fi
if [[ -z $S ]] && [[ $f = f ]]; then S=E ; f= ; echo " Option Errors" ; fi
## -Sv
if [[ $v = v ]] && [[ $S = S ]]; then S=-Sv ; v= ; fi
## -Sf
if [[ $f = f ]] && [[ $S = S ]]; then S=-Sf ; f= ; fi
## -S
if [[ -z $v ]] && [[ $S = S ]]; then S=-S ; v= ; fi
if [[ -z $f ]] && [[ $S = S ]]; then S=-S ; f= ; fi
## RUN ###=====================================
if [[ $S = -S ]]; then echo " run : install function" ; fi
if [[ $S = -Sv ]]; then echo " run : update function " ; fi
if [[ $S = -Sf ]]; then echo " run : force function " ; fi
progs="${@}"
echo "
S : $S
v : $v
f : $f
R : $R
C : $C
D : $D
F : $F
s : $s
p : $p
h : $h
\$@ : ${@}
\$progs : $progs
"
echo "${@}" >/tmp/prgs
Some test results of "getopts drop in replacement" above.
$ getopz -S pkg1 pkg2
$ getopz -S pkg1 pkg2
Function
$@ : -S pkg1 pkg2
$progs :
$prgs : - S pkg1 pkg2
========================================
run : install function
S : -S
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -Sv pkg1 pkg2
$ getopz -Sv pkg1 pkg2
Function
$@ : -Sv pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
run : update function
S : -Sv
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -S -v pkg1 pkg2
$ getopz -S -v pkg1 pkg2
Function
$@ : -S -v pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
run : update function
S : -Sv
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -v -S pkg1 pkg2
$ getopz -v -S pkg1 pkg2
Function
$@ : -v -S pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
run : update function
S : -Sv
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -vS pkg1 pkg2
$ getopz -vS pkg1 pkg2
Function
$@ : -vS pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
run : update function
S : -Sv
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -v -S pkg1 pkg2
$ getopz -v -S pkg1 pkg2
Function
$@ : -v -S pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
run : update function
S : -Sv
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -v -Sf pkg1 pkg2
$ getopz -v -Sf pkg1 pkg2
Function
$@ : -v -Sf pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
Option Errors
S : E
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -Sf pkg1 pkg2
$ getopz -Sf pkg1 pkg2
Function
$@ : -Sf pkg1 pkg2
$progs :
$prgs : pkg1 pkg2
========================================
run : force function
S : -Sf
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
$ getopz -v pkg1 pkg2
$ getopz -v pkg1 pkg2
Option Errors
S : E
v :
f :
R :
C :
D :
F :
s :
p :
h :
$@ : pkg1 pkg2
$progs : pkg1 pkg2
ETC............
aurt script: Builds and installs AUR packages.
#!/bin/bash
# aurt 01-10-18 Depencencies: sudo base-devel git cower pacutils
basedir="${HOME}"/z-AUR-Aurt # "${basedir}" = base directory for build
builddir="${HOME}"/z-AUR-Aurt/"${2}" # "${builddir}" = build directory
pdate=$(date '+%Y-%m-%d') # "${pdate}" = todays date
#===================================================== INSTALL =====================================================
install () {
if [[ -z ${2} ]]; then echo "Error: No package"; exit
fi
exec &> >(tee -i "${basedir}/${2}.log")
### Check if package is installed, if yes bypass, if no proceed to next test
### Check if AUR git repo is available, if yes git clone, if no, print massage and exit aurt
if [[ $(pacman -Q "${2}" 2>/dev/null | awk '{print $1}') != "${2}" ]]; then
if [[ -n $(git ls-remote https://aur.archlinux.org/"${2}".git) ]]; then
cd "${basedir}" || exit
git clone --progress https://aur.archlinux.org/"${2}".git #> /dev/null
else
echo; echo "Error: AUR git repo for ${2} is unavailable"; echo; exit
fi
fi
cd "${builddir}" || exit
### Check if package is installed, if yes bypass to check for updates, if no next test
### Check if PKGBUILD is present, if yes run interactive function, build package and exit aurt, if no, display message, exit
if [[ $(pacman -Q "${2}" 2>/dev/null | awk '{print $1}') != "${2}" ]]; then
if [[ -s PKGBUILD ]]; then
### Print info from aurt-help ### Run interactive function
. aurt-help --pkgbuild
stopYesNo
makepkg -si --needed --noconfirm ; exitcode1=$? ; # echo; echo " makepkg pos 1 exit code: $exitcode1"
# echo; echo " ${2} has been installed."; echo; exit
else
echo; echo "Error: PKGBUILD unavailable, to restore, remove then reinstall package with aurt"; echo; exit
fi
fi ### Use git HEAD local vs remote to check update status, if different run checkupdate function, if same display message, exit
if [[ $(git ls-remote https://aur.archlinux.org/"${2}".git HEAD|awk '{print $1}') != $(git -C "${builddir}" rev-parse HEAD) ]]; then
local=$(git -C "${builddir}" rev-parse HEAD) ####| != |#### default present
checkupdate "${@}"
else echo; echo " Local git HEAD : $(git -C "${builddir}" rev-parse HEAD)"
echo " Remote git HEAD : $(git ls-remote https://aur.archlinux.org/"${2}".git HEAD | awk '{print $1}')"; echo
echo " ${2} up to date, nothing to do."
if [[ -n $(echo $exitcode) ]] && [[ $(echo $exitcode) != 0 ]]; then
echo "Aurt detected makepkg in install exited with ERROR (non zero exit code 1: $exitcode1). Read makepkg output to troubleshoot."
echo
else echo "${pdate} installed ${2}" >> "${basedir}"/A-Aurt-Install.log
fi
fi
}
#=================================================== CHECK UPDATE ==================================================
checkupdate () {
local=$(git -C "${builddir}" rev-parse HEAD)
### Check builddir present, if no message & exit aurt
if [[ ! -d ${builddir} ]]; then
echo " Build directory is not present, reinstall package." ; exit
fi
### Check if .git dir available, if yes, git pull & makepkg to get latest available version number
if [[ -d ${builddir}/.git ]]; then
cd "${builddir}" || exit
git pull --progress https://aur.archlinux.org/"${2}".git 2> /dev/null
makepkg -so #2> /dev/null ; exitcode2=$? ; # echo; echo " makepkg pos 2 exit code: $exitcode2"
fi
### Compare local to remote git HEAD numbers, if different, proceed
avalver="$(makepkg --printsrcinfo|awk -F'=' '/pkgver/,/pkgrel/ {print $2}'|tr -d ' '|paste -d'-' - -)"
# avalver="$(makepkg --printsrcinfo 2> /dev/null|sed -n '/\s*pkg[vr]e[rl]/{s/[^=]*= //;H}; ${x;s/\n//;s/\n/-/p}')"
if [[ $(pacman -Q "${2}" | awk '{print $2}') != "${avalver}" ]]; then
####| != |#### default present
### Print info from aurt-help ### Run interactive function ### Build and install package
. aurt-help --pkgbuild
. aurt-help --updates "${2}"
stopYesNo
cd "${builddir}" || exit
makepkg -fsi --needed ; exitcode3=$? ; # echo; echo " makepkg pos 3 exit code: $exitcode3"
echo "updated on ${pdate}" >> "${builddir}"/Aurt-Update.log
echo; echo " ${2} has been updated."; echo
else
echo "checked on ${pdate}" >> "${builddir}"/Aurt-Update.log
. aurt-help --updates "${2}"
echo " ${2} is up to date, Exiting. "; echo
if [[ -n $(echo $exitcode) ]] && [[ $(echo $exitcode) != 0 ]]; then
echo "Aurt detected makepkg in update exited with ERROR (non zero exit code 2&3: $exitcode2 $exitcode3)."
echo
fi
fi
}
#=============================================== FORCE INSTALL UPDATE ==============================================
forcebuild () {
if [[ -z ${2} ]]; then echo "Error: No package"; exit
fi
if [[ -d ${builddir} ]]; then
mv "${builddir}" "${builddir}".aurt-BU
fi
cd "${basedir}" || exit
git clone https://aur.archlinux.org/"${2}".git
cd "${builddir}" || exit
makepkg -fsi
echo; echo " NOTE: If ${builddir} was present, it has been renamed to ${2}.aurt-BACKUP".
}
#=================================================== INTERACTIVE ===================================================
stopYesNo () {
echo " ^ SEE PKGBUILD ABOVE ^ "; echo
echo " Proceed install/update package with[y] / without[n] editing PKGBUILD."
echo " Edit PKGBUILD? [y][yes] / [n][no] "
echo " Note: exit editor upon completion to proceed with update. "; echo
echo " EXIT NOW: Do not install / update. [e][exit]"; echo
while true; do read -r -p " Please Select: [y]/[n]/[e] " yne
case $yne in
y|yes) $EDITOR PKGBUILD; break ;;
n|no) break ;;
e|exit) exit ;;
* ) echo "y-n ?" ;;
esac
done
}
#===================================================== REMOVE ======================================================
remove () {
if [[ -z ${2} ]]; then echo "Error: No package"; exit; fi
exec &> >(tee -i "${basedir}/${2}.log")
echo " NEXT: Runing sudo pacman -Rns --noconfirm ${2}, and sudo rm -fr ${builddir}"; echo
while true; do read -r -p " Proceed? [Y/n] " yn
case $yn in
y|yes) break ;;
n|no) exit ;;
* ) echo "y-n ?" ;;
esac
done
rm -fr "${builddir}"
rm "${basedir}"/"${2}".log
sudo pacman -Rns --noconfirm "${2}"
}
#===================================================== SEARCH ======================================================
search () {
cower -qs --by=name "${2}"
number=$(cower -qs --by=name "${2}" | wc -l)
echo; echo " Found: ${number} packages above with ${2} in name."; echo
echo " If there is an exact match, details shown below. " ; echo
cower -i "${2}"
}
#================================================ DEPENDENCY DETAILS ===============================================
dependencies () {
uXoff=
uXaur=
cower -i --format=%D --listdelim=' ' "${2}" |fmt -1 >/tmp/deps # Get package deps raw list
if [[ ! -s /tmp/deps ]]; then echo "Dependency info for ${2} is unavailable."; exit # exit if no results
fi #
cower -i --format=%M --listdelim=' ' "${2}" |fmt -1 >/tmp/mdeps # Get makedeps raw list
cp /tmp/deps /tmp/mu-allraw # Copy deps to mu-allraw
cat /tmp/mdeps >> /tmp/mu-allraw # Combine deps, mdeps to mu-allraw
awk -F'[<]|>' '{print $1}' /tmp/mu-allraw >/tmp/mu-ans # remove >, <, & all trailing
sort /tmp/mu-ans >/tmp/mu-all # = met & unmet-all sorted # [met unmet all]
pacman -Qq $(</tmp/mu-all) 2>/dev/null >/tmp/m-all # = met-all # [met all]
comm -23 /tmp/mu-all /tmp/m-all >/tmp/u-all # = unmet-all # [ unmet all]
pacinfo --short $(</tmp/u-all) 2>/dev/null >/tmp/u-off-2 # = unmet-official repo (to filter) #
awk -F'/' '/core|extra|community|multilib/ {print $2}' /tmp/u-off-2 >/tmp/u-off-1 # = unmet-official repo (filtering) #
awk 'NF {print $1}' /tmp/u-off-1 >/tmp/u-off # = unmet-official repo (filtered) # [ unmet off]
comm -23 /tmp/u-all /tmp/u-off >/tmp/u-aur # = unmet-aur repo # [ unmet aur]
if (( $(cat /tmp/mu-all|wc -c) > 125 )); then # If list too wide, display as column
cdc="$(cat /tmp/deps |fmt -1)"
else
cdr="$(cat /tmp/deps|fmt -125)"
fi
cmd="$(cat /tmp/mdeps|fmt -125)"
uXoff="$(cat /tmp/u-off|fmt -125)"
uXaur="$(cat /tmp/u-aur|fmt -125)"
. aurt-help --depend "${2}"
#===================================================================================================================
}
updatereport () {
echo
cower -uv; echo
echo " Number of AUR packages installed & checked: $(cower -uv |tee | wc -l)"; echo
}
parametererror () {
echo
echo " Input Error: Please try again or see aurt --help"
}
#================================================== RUN FUNCTIONS ==================================================
if [[ -z "$*" ]]; then aurt-help --header "${@}"
fi
while :; do
case "${1}" in
-S|--install) install "${@}" ;;
-Sc|--checkversion) checkupdate "${@}" ;;
-Sf|--force) forcebuild "${@}" ;;
-R|--remove) remove "${@}" ;;
-C|--checkupdates) updatereport ;;
-D|--dependencies) dependencies "${@}" ;;
-F|--files) pacman -Ql "${2}" ;;
-s|--search) search "${@}" ;;
-p|--pacmanlog) paclog ;;
-h|--help) aurt-help --help "${@}" ;;
-?*) parametererror; aurt-help --header ;;
*) break
esac
shift
done
aurt-help script: Prints user info to screen.
#!/bin/bash
# aurt-help.1-10-18
header () {
cat << Read-Header
|=====================================================================================|
| Aurt, a tiny AUR helper script. USAGE: \$ aurt [operation] [package] |
|-------------------------------------------------------------------------------------|
| -S Install Or Update -F Files Provided By Pkg NOTES: |
| -Sv Update By Version -s Search For Pkg |
| -Sf Force Install Or Update -p Pacman Log |
| -R Remove Pkg And Bld Dir -h Help leafpad-aurt: lat |
| -C Ck All Pkgs For Updates thunar-base dir: tbd |
| -D Package Dependency Details Orphans: R \$(p -Qtdq) |
|=====================================================================================|
Read-Header
}
help () {
cat << Read-Help
Usage: aurt <operation> [AUR package name]
Operations:
-S = Install and or update package.
-Sv = Check version number status, update.
-Sf = Force install and or update package.
-R = Remove package.
-C = Check all packages for update.
-D = Dependency details for package.
-F = List of files provided by package.
-s = Search for package.
-p = Display pacman.log.
-h = Aurt help, this page.
Overview:
-S Checks if package is installed, builds, installs, else checks for updates and update in this order.
-Sv Check package for updates based on version numbers and update. (See details below)
-Sf Force install or update backs up build directory to /path/[packagename].aurt-BU, re-builds and or re-installs package.
-R Performs pacman -Rns on package and deletes package build directory and log.
-C Displays list of all installed AUR packages and update status via cower.
-D Displays details on package dependencies, installed or not via cower, pacman, pacinfo, and aurt.
-F Displays a list of all the files belonging to a package.
-s Displays list of search results for package and details if match is found via cower.
-p Displays pacman log file.
-h Displays this help page.
-Sv Details: Aurt -S operation makes use of git HEAD local vs remote to check update status.
In case of git related issues preventing update, the -Sv operation should be used,
which bypasses the default, if 'git HEAD [local=remote] exit' test. The -Sv operation
still performs the .SCRINFO version number test to determine if an update is available.
Read-Help
}
updates () {
# local=$(git -C "${builddir}" rev-parse HEAD) # Getting "local" variable prior (~ line 48 aurt) to git pull.
installed=$(pacman -Q "${2}" | awk '{print $2}')
remote=$(git ls-remote https://aur.archlinux.org/"${2}".git HEAD | awk '{print $1}')
cat << Read-updates
------------------------------------------------------------------------
git HEAD status
Local : ${local}
Remote : ${remote}
------------------------------------------------------------------------
Details
Todays date: : ${pdate}
Package : ${2}
Base Directory : ${basedir}
Build directory : ${builddir}
Installed version : ${installed}
Latest available version : ${avalver}
------------------------------------------------------------------------
Read-updates
}
pkgbuild () {
catpkgbuild=$(cat PKGBUILD) # "${pkgbuild}" = used in aurt-help, pkgbuild function
cat << Read-pkgbuild
=========================================================================
START PKGBUILD
=========================================================================
${catpkgbuild}
=========================================================================
END PKGBUILD
=========================================================================
Read-pkgbuild
}
depend () {
cat << Read-deps
----------------------------------------------------------------------------------------------------------------
Package : ${2}
Unmet AUR repo : ${uXaur}
Unmet Official repo : ${uXoff}
Make Dependancies : ${cmd}
Dependancies : ${cdr}
${cdc}
----------------------------------------------------------------------------------------------------------------
Install all required AUR dependencies prior to installing ${1}.
----------------------------------------------------------------------------------------------------------------
Read-deps
}
while :; do
case "${1}" in
--header) header ;;
--help) help ;;
--updates) updates "${@}" ;;
--pkgbuild) pkgbuild ;;
--depend) depend "${@}" ;;
*) break
esac
shift
done
Suggestions for learning more about shell scripting? I tend to learn more using a "hands on" approach than reading at this point. Most of the terse man pages and documentation I find, imply an underlying understanding of terminology and concepts, much of which I currently do not posess.
Thanks for any help.