Suggestions/Recommendations for coding

#!/bin/sh
#set -x
uploaddir="/u01/app/informatica/dev3/sample/GPMDir/UploadDir"
processdir="/u01/app/informatica/dev3/sample/GPMDir/ProcessDir"
datetime=`date +%Y%m%d`
logdir="$processdir/GPMLogFile_$datetime.log"

echo "<---------------Start Copying & Moving GPM Files To Process Directory-------------->" > $logdir

cat /dev/null >$processdir/dummy.txt
echo "Creating A Dummy File In The Process Directory" >> $logdir

rm -rf $processdir/*.list
echo "Removed All The List Files Generated Earlier In The Process Directory" >> $logdir

cd $uploaddir
echo "Current Directory Path Is:" >> $logdir
echo "`pwd`" >> $logdir

if [ -f "$uploaddir"/"GPM_"*".csv" ];then
	cp $uploaddir/GPM_*.csv $processdir
          if [ $? -eq 0 ] ; then
          echo "Master GPM Files Were Copied Successfully Into Process Directory" >> $logdir
          else
	  echo "Error In Copying Master GPM Files Into Process Directory" >> $logdir
          fi
else 
	echo  "Master GPM Files Doesn't Exists In Upload Directory, Hence Cann't Copy Over The Files Into The Process Directory" >> $logdir
fi

if [ -f "$uploaddir"/*"_FI.csv" ]; then
		for i in `ls -rt *_FI.csv`
		do
			echo $processdir/$i>> $processdir/GPM_FI.list
			cp $uploaddir/$i $processdir
			#mv $uploaddir/$i $processdir
		done
	echo "FI Files Exists, Generated The FI File List & Copied Over The FI Files Successfully Into The Process Directory" >> $logdir
else 
	echo "FI Files Doesn't Exists,Creating Dummy File List" >> $logdir
	ls -rt $processdir/dummy.txt > $processdir/GPM_FI.list
fi
#!/bin/sh
#set -x
processdir="/u01/app/informatica/dev3/sample/GPMDir/ProcessDir"
archivedir="/u01/app/informatica/dev3/sample/GPMDir/ArchiveDir"
zipfilename="$archivedir"/"GPMArchivedFiles_"`date +%y%m%d`".zip"

echo "<-----------Starting Archiving Of GPM Files For `date +%Y%m%d`-------------->" >> $archivedir/GPMArchive.log

cd $processdir
echo "The Current Directory Path Is:" >> $archivedir/GPMArchive.log
echo "`pwd`" >> $archivedir/GPMArchive.log

for i in `ls -rt *.csv *.log GPM_*.list`
do
echo $i >> $processdir/ArchiveFiles.list
done

while read line
do
zip -mqj $zipfilename $line
if [ $? -eq 0 ];then
echo "$line File Has Been Added To The Zip File $zipfilename"
else
echo "Error In Adding $line To The $zipfilename"
fi
done < $processdir/ArchiveFiles.list