I have converted the posts (each of the main posts) from table tags to div tags and the problem with the scroll bar and code tags is fixed, as I predicted (Yay!).
Now I'm testing this (only I see the new results because the new code is restricted to my userid) but I would like others to test before I cut over for everyone.
Please let me know if you want to be a part of the test.
Basically, it seems to work very well (my testing) and the scrollbars work excellently in all code tags widths.
I just checked a few posts where the formatting was previously shocking and it now looks good. Brilliant.
For example this one:
The text overflowed to the right but the scroll bar was below the image so could not scroll easily at all. Now the text is formatted nicely so scrolling not necessary. However, should we be able to see the full image posted??
Nothing to complain about, on a first, quick glance. Very good!
Yes, I can confirm the multiquote problem.
Not sure if this belongs here: Nice working horizontal scrollbar on code tagged text; do you think that were possible for long vertikal code text (example post) as well, limiting the box to, say, two thirds of the screen?
EDIT: Ah, and the "quick reply" bubble in each post doesn't bring me to the small "quick reply" editor but to the advanced editor. Doesn't really hurt, though.
Should that editor be subject to our tests as well?
Coders who can code in HTML5, CSS3 and Javascript/jQuery would be nice.
This is a fairly huge site with nearly a million posts and countless lines of code, much of it modified over the years by various admins who are not active now.
Currently, there is only one administrator actively coding, and his name is Neo, LOL, so for the first time since our early days, we only have one admin working on code.
Thanks for your patience. It you really want to complain about some feature or desirable switch, write the code and fix it is actually better. LOL
I'm going to rewrite and modernize the code base here, even if some complain strongly, because everyone is free to write code to add great features versus complaining. This is a site for techies and coders. Write code! LOL
To be honest I am not that great developer and never worked on such a big project like this forum. But if you could give me a test site or any test server/qa server(if this site has any), I will give my 110% to help. But honestly I am not html/java script guy but some guidance and some qa test/servers/site if I get I may try out few things and could help you
That will not work for me, because what you are asking takes time away from coding.
To be a web developer and to be able to help, you need to be self-sufficient 100%, and if your are not an HTML/JS person, this site is not place to start learning.
OK... I fixed the bug with multi-quoting. It works great now (I think). There was some extra div elements in the version from tables to divs and I squashed a number of those bugs.
Also, I added a new multi-quote function where if we doubleclick on the multi-quote icon, it clears the entire multi-quote cookie entry.
function mq_dblclick(){
var D = fetch_cookie("vbulletin_multiquote");
if(D){
A = D.split(",");
for (var B = 0; B < A.length; B++) {
var F = "mq_"+A;
$("#"+F).removeClass("fas");
$("#"+F).addClass("far");
$("#"+F).attr("title","Click to Select this Post to Quote in Reply");
}
set_cookie("vbulletin_multiquote",'');
}
return false;
}
By adding the line in red below to the mq_init() function:
function mq_init(D) {
var C = fetch_cookie("vbulletin_multiquote");
if (C != null && C != "") {
C = C.split(",");
} else {
C = new Array();
}
var E;
var A = fetch_tags(D, "i");
for (var B = 0; B < A.length; B++) {
if (A.id && A.id.substr(0, 3) == "mq_") {
E = A.id.substr(3);
A.onclick = function(F) {
return mq_click(this.id.substr(3));
};
E = A.id.substr(3);
A.ondblclick = function(F) {
return mq_dblclick();
};
change_mq_image(E, PHP.in_array(E, C) > -1 ? true : false);
}
}
}
I'll test it more before enabling this again for the testing crew.
OK! The new post code is live again for the testing crew:
$testers = array('1','302122047','302108573','302148617');
if (NEO_WORKING AND in_array($vbulletin->userinfo['userid'],$testers))
{
// now live new postbit code
}
If anyone else wants to help out and test, please raise your hand.
Thanks.
PS: The overflow issues with code and big images in posts should be solved (scrollbars working).
Also, multi-quote works well, and I added a few feature to clear all selected posts by doubleclicking on the multi-quote icon.
a smiley what we say it (Face With Stuck-Out Tongue, I believe) too here?
