If then else script

Hey , i am trying to automate how we collect logs in isilon.

echo "This will fetch you the disk details"
echo "which node do you want to check? Enter Values 1-18"
read node
echo $node
if [ $node -eq 1 ]
then
                   echo "You have seclected node 1";
                   for i in 192.168.1.1 ; do ssh -o UserKnownHostsFile=/dev/null root@$i isi devices; done


elif [ $node -eq 2 ];
then
                   echo "You have seclected node 1";
                   for i in 192.168.1.2 ; do ssh -o UserKnownHostsFile=/dev/null root@$i isi devices; done
else
echo "Wrong Choice"
fi

I get the below error when i run this script:

[QQQQ@XXXX ~]$ ./isitest.sh 
This will fetch you the disk details
which node do you want to check? Enter Values 1-18
1
1
./isitest.sh: line 8: syntax error near unexpected token `do'
./isitest.sh: line 8: `               for i in 192.168.1.1; do ssh -o UserKnownHostsFile=/dev/null root@$i isi devices; done'

Can anyone please help , where i am missing something?

There is nothing wrong the the code - at least not what is visible.

Can you post the output, first, of:

cat -v script

And say what OS and shell you are using.

I do not see the need to use a for loop range construct here.

Have you been successful running root@192.168.1.1 isi devices manually?
I bet you, you need to surround the remote command within (') marks

root@192.168.1.1 'isi devices'

Thanks Guys, Yes there is no need for the for loop here but it should still work never the less.

[YYY@XXX ~]$ cat -v isitest.sh
echo "This will fetch you the disk details"
echo "which node do you want to check? Enter Values 1-18"
read node
echo $node
if [ $node -eq 1 ]
then
M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- echo "You have seclected node 1";
    M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- for i in 192.168.1.1; do ssh -o UserKnownHostsFile=/dev/null root@$i isi devices; done


elif [ $node -eq 2 ];
then
M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- echo "You have seclected node 1";
        M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- M-BM- for i in 192.168.1.2 ; do ssh -o UserKnownHostsFile=/dev/null root@$i isi devices; done
else
echo "Wrong Choice"
fi

Yes , i have been successfull in runing manually.

[YYY@XXX~]$ for i in 192.168.1.1 ; do ssh -o UserKnownHostsFile=/dev/null root@$i isi devices; done
The authenticity of host '192.168.1.1(192.168.1.1)' can't be established.
DSA key fingerprint is 5e:2b:f6:80:b6:62:33:78:f5:6f:00:32:a4:f7:d0:f7.
Are you sure you want to continue connecting (yes/no)? ^C

:mad:

Was this script created in another OS?
You need to clear the space/hidden characters.
Open the the script file with the current system editor and substitute any amount of white space for a local space, (no tab).

Thanks!! this is resolved. I had initially copied this script for a notepad.
Appreciate the help:b: