# Feedback on Script.

**URL:** <https://community.unix.com/t/feedback-on-script/140661>\
**Category:** Shell Programming and Scripting\
**Created:** [December 15, 2001, 9:52am UTC](https://community.unix.com/t/feedback-on-script/140661 "2001-12-15T09:52:32Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![Cameron](https://community.unix.com/user_avatar/community.unix.com/cameron/32/41_2.png) [@Cameron](https://community.unix.com/u/Cameron)\
**Post date:** [December 15, 2001, 9:52am UTC](https://community.unix.com/t/feedback-on-script/140661/1 "2001-12-15T09:52:32Z")

</div>

Hi all,

Would like to get some feedback on a scrip that I've finished writing at home for work.

Any constructive feedback from operations used to legibility, etc. would be appreciated - anything at all. It's my first real script that will be running on a clients server.

The script is [Monthly\_sar](http://www.powerup.com.au/~cammy/unix-linux/monthly_sar.txt) .  
A copy of one of the data files being read is [here](http://www.powerup.com.au/~cammy/unix-linux/SAR09.txt) .

Cheers,  
Cameron

---

<div class="post-metadata">

**Author:** ![Neo](https://community.unix.com/user_avatar/community.unix.com/neo/32/22838_2.png) [@Neo](https://community.unix.com/u/Neo)\
**Post date:** [December 15, 2001, 10:35am UTC](https://community.unix.com/t/feedback-on-script/140661/2 "2001-12-15T10:35:36Z")

</div>

Quick feedback:

[list=1]  
[_]No Version Control in script (version number, date).  
[_]No author information or revision history.  
[\*]No URL to archive where updated source may be found.  
[/list=1]  
Just my quick thoughts. The last one might not be so important, but the first two are, even if the script is only used by one person.

---

<div class="post-metadata">

**Author:** ![Cameron](https://community.unix.com/user_avatar/community.unix.com/cameron/32/41_2.png) [@Cameron](https://community.unix.com/u/Cameron)\
**Post date:** [December 16, 2001, 9:32am UTC](https://community.unix.com/t/feedback-on-script/140661/3 "2001-12-16T09:32:17Z")

</div>

Thanks Neo.
