Here is heavily abbreviated (ie not validating user input) C-code for generating weights in a smoothing function: #include <stdio.h> #include <stdlib.h> #include <string.h> #include <math.h> #define PERIODS 40 /* function to generate weights */ float *weights (char wf[9], float k, float lambda) {…

+1 to the technique of passing a function pointer into weights(). (The argv[1] reference works because there will always be an argv[1], although it may be NULL, and b/c of the tertiary operator used in the function call.) @technossomy Your original weights() function puts if statements inside the …

Hi @technossomy , I am a bit surprised that smooth works without an argument, because then argv[1] is not defined. That's what argc is for. I would also write a separate function per weight method, and pass the function pointer to weights. This avoids the repeated if/else in the loop. Also, define w…

unless there's a specific reason it needs to be 9 bytes in size? char *wf will do as it is passed by reference const char *wf if you want it not to be changed during the function call - would generate a compile time error typically. ie: float *weights( char *wf, float k , float lambda)... float…

[image] munkeHoller: unless there's a specific reason it needs to be 9 bytes in size? Fair point. There are other smoothing functions, the longest of which is 9 characters in length. [image] munkeHoller: I recommend you try the alternative declarations/definitions. BendingRodriguez co…

bendingrodriguez , this is excellent. To summarise your additions: Use of argc to trap possibility of no user-provided input Separate function per smoothing function Introduction of void wrapper function and pass a function pointer as function argument Single declaration of weights array w[x] Intro…

By the way, upon compilation of bendingrodriguez code I am getting the following error message: smooth.c:9:7: error: conflicting types for ‘gamma’ 9 | float gamma(int x, float k, float lambda) { return pow(x/lambda, k-1) * exp(-x/lambda); } | ^~~~~ In file included from /usr/include…

[image] technossomy: Any idea how I can circumvent this message? Make sure you are typing consistently. A quick glance looks like you are mixing float (32 bit) and double (64 bit).

presuming you are using <math.h>, i recommend you read the documentation, as for 'circumventing' the message, its simple, understand the tools you are using. here's a couple of links to help you https://www.tutorialspoint.com/c_standard_library/c_function_exp.htm https://www.tutorialspoint.com/c…

Hi @technossomy , since it is not really necessary to name the functions in the same way as the arguments (it's only a mapping string -> function), you can simply give them (the functions, not the arguments) a slightly modified name, e.g. w_gamma() or gamma_w() (btw I don't get that error, it could …

Also, @technossomy It's easy to understand your confusion. Programming languages can be strong or weakly typed. It might help you to review this wiki page on this topic. Strong and weak typing Pages for logged out editors learn more In computer programming, one of the many w…

[image] Azhrei: Your original weights() function puts if statements inside the loop, which should be avoided for performance reasons (and is likely why you posted your question in the first place!). Agreed on the use of function pointers being cleaner, but performance was not the reason for p…

Unix Linux Community

C programming: string definition question

Applications Programming

show post in topic

Home
Categories
Guidelines
Terms of Service
Privacy Policy

Powered by Discourse, best viewed with JavaScript enabled